Use sphinx-galery 0.9 and simplify conf.py #3724
Conversation
| @@ -1,5 +1,5 @@ | |||
| sphinx==2.4.4 | |||
| sphinx-gallery | |||
| sphinx-gallery>=0.9.0 | |||
| matplotlib | |||
| numpy | |||
There was a problem hiding this comment.
Actually, we can avoid numpy dependency. matplotlib covers it?
There was a problem hiding this comment.
You're right, but it doesn't hurt to be explicit for those things IMHO.
Who knows: we might end up not using matplotlib for showing images, or mpl may even not depend on numpy at some point (quite unlikely I agree)
There was a problem hiding this comment.
I think the best practice is to we avoid transitive dependencies and define explicitly. With a quick look on the documentation folder, I don't see a direct import on numpy (only some references on the config) but if it is a necessary dependency I would leave it explicitly defined for the reasons that Nicolas explained.
There was a problem hiding this comment.
We have an explicit dep on numpy in gallery/plot_transforms.py which isn't in the doc folder, but it's still part of the doc building
Reviewed By: NicolasHug Differential Revision: D28169119 fbshipit-source-id: 7788887d3dcfad87bfeeaccfb5f49d068b209395
Now that sphinx-gallery 0.9 is released, we can simplify the logic of
inject_minigalleries().