Proper error message #3725
Proper error message #3725
Conversation
Now when there are missing ffmpeg libraries the error displayed is:
```
{0} header files were not found, disabling ffmpeg.
```
This is because the missing `.format`.
This PR fixes the warning message by appending the proper format operation.
|
Hi @Guillem96! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
setup.py
Outdated
| @@ -375,7 +375,7 @@ def get_extensions(): | |||
|
|
|||
| if not library_found: | |||
| print('{0} header files were not found, disabling ffmpeg ' | |||
| 'support') | |||
| 'support'.format(library)) | |||
There was a problem hiding this comment.
Nit: we could use f-strings now
Summary:
* Proper error message
Now when there are missing ffmpeg libraries the error displayed is:
```
{0} header files were not found, disabling ffmpeg.
```
This is because the missing `.format`.
This PR fixes the warning message by appending the proper format operation.
* Use f-string
Reviewed By: NicolasHug
Differential Revision: D28169143
fbshipit-source-id: 205f5467c92a9d5d930d6e28e20ba9b02980120b
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>
Now when there are missing ffmpeg libraries the error displayed is:
This is because the missing
.format.This PR fixes the warning message by appending the proper format operation.