Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Ported places365 dataset's tests to the new test framework"" #3731

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Revert "Revert "Ported places365 dataset's tests to the new test framework"" #3731

merged 1 commit into from
Apr 26, 2021

Conversation

prabhat00155
Copy link
Contributor

Reverts #3718

@prabhat00155 prabhat00155 requested a review from datumbox April 26, 2021 10:15
@prabhat00155 prabhat00155 requested a review from pmeier April 26, 2021 10:15
pmeier
pmeier approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revertception

datumbox
datumbox approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

"We got to revert deeper"

@datumbox
Copy link
Contributor

@prabhat00155 since our CI is toasted these days, could you run the relevant tests locally before merging? Just to be safe. :)

@prabhat00155 prabhat00155 merged commit ae63bd0 into master Apr 26, 2021
@fmassa fmassa deleted the revert-3718-revert-3705-prabhat00155/port_places365 branch April 26, 2021 11:46
facebook-github-bot pushed a commit that referenced this pull request May 4, 2021
@cpuhrsch @facebook-github-bot
[fbsync] Revert "Revert "Ported places365 dataset's tests to the new …
452c4e7 
…test framework (#3705)" (#3718)" (#3731)

Summary: This reverts commit d419558.

Reviewed By: NicolasHug

Differential Revision: D28169118

fbshipit-source-id: 64dd4045e47e6f308e229a8a83a2d2ae29378408
@NicolasHug NicolasHug added module: datasets module: tests revert(ed) For reverted PRs, and PRs that revert other PRs labels May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: datasets module: tests revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prabhat00155 @datumbox @pmeier @NicolasHug @facebook-github-bot