[FBcode->GH] Parametrize test_perspective (#3748) #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#3748 This PR parametrizes the `perspective`-related tests, and avoids having deeply nested for-loops which will help debugging. "What" gets tested is left unchanged. The newly-introduced `cpu_and_gpu()` generator along with the `dont_collect` mark is a logic that allows to not run CPU tests on GPU machines (and vice versa). Reviewed By: fmassa Differential Revision: D27908299 fbshipit-source-id: 24a10a89fe90ae0a9e62de4bc7e768a669ebf212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #3748
This PR parametrizes the
perspective-related tests, and avoids having deeply nested for-loops which will help debugging. "What" gets tested is left unchanged.The newly-introduced
cpu_and_gpu()generator along with thedont_collectmark is a logic that allows to not run CPU tests on GPU machines (and vice versa).Reviewed By: fmassa
Differential Revision: D27908299
fbshipit-source-id: 24a10a89fe90ae0a9e62de4bc7e768a669ebf212