Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored set_cell_anchors() in AnchorGenerator #3755

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Refactored set_cell_anchors() in AnchorGenerator #3755

merged 3 commits into from
Apr 30, 2021

Conversation

prabhat00155
Copy link
Contributor

Resolves #3667.

@prabhat00155 prabhat00155 requested a review from datumbox April 29, 2021 22:45
datumbox
datumbox approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one minor non-blocking suggestion for your consideration.

torchvision/models/detection/anchor_utils.py Outdated Show resolved Hide resolved
@prabhat00155
Copy link
Contributor Author

There are some test failures, looking into them.

@prabhat00155 prabhat00155 merged commit 7c35e13 into pytorch:master Apr 30, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/refactor_anchor branch April 30, 2021 11:39
facebook-github-bot pushed a commit that referenced this pull request May 4, 2021
@cpuhrsch @facebook-github-bot
[fbsync] Refactored set_cell_anchors() in AnchorGenerator (#3755)
f766afa 
Summary:
* Refactored set_cell_anchors() in AnchorGenerator

* Addressed review comment

* Fixed test failure

Reviewed By: NicolasHug

Differential Revision: D28169121

fbshipit-source-id: 1b6d9bcec0b69eedc67761796bb110befdc377c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: models topic: object detection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching disabled on AnchorGenerator
3 participants
@prabhat00155 @datumbox @facebook-github-bot