-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added antialias option to transforms.functional.resize #3761
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
45a643c
WIP Added antialias option to transforms.functional.resize
vfdev-5 5cb18b5
Updates according to the review
vfdev-5 0e10604
Excluded these C++ files for iOS build
vfdev-5 4d2b42c
Merge branch 'master' into vfdev-5/interpolate-aa-cpu
vfdev-5 c2247de
Added support for mixed downsampling/upsampling
vfdev-5 379d91f
Fixed heap overflow caused by explicit loop unrolling
vfdev-5 e0c416d
Merge branch 'master' into vfdev-5/interpolate-aa-cpu
vfdev-5 e2e9936
Merge branch 'master' into vfdev-5/interpolate-aa-cpu
vfdev-5 b23f637
Merge branch 'master' into vfdev-5/interpolate-aa-cpu
vfdev-5 0e855f3
Merge branch 'master' into vfdev-5/interpolate-aa-cpu
vfdev-5 4b641ed
Applied PR review suggestions
vfdev-5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the port! Just 2 nits: we probably don't need the
device
andinterpolation
parametrizations since they only have one element, so I'd suggest to remove them. Should we need them in the future, it will be very easy to add backThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I agree but as mentioned in the description, in the follow-up PRs we aim to add more interpolation modes and CUDA support, that's why I kept them.