Skip r2plus1d_18 test on linux GPU Circle CI machines #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 4, 2021
test/common_utils.py
Outdated
| @@ -23,7 +23,7 @@ | |||
| IS_PY39 = sys.version_info.major == 3 and sys.version_info.minor == 9 | |||
| PY39_SEGFAULT_SKIP_MSG = "Segmentation fault with Python 3.9, see https://github.com/pytorch/vision/issues/3367" | |||
| PY39_SKIP = unittest.skipIf(IS_PY39, PY39_SEGFAULT_SKIP_MSG) | |||
|
|
|||
| IN_CIRCLE_CI = os.getenv("CIRCLECI", 'false') == 'true' | |||
There was a problem hiding this comment.
datumbox
approved these changes
May 4, 2021
NicolasHug
commented
May 4, 2021
| @@ -648,7 +648,7 @@ jobs: | |||
| command: docker run -t --gpus all -v $PWD:$PWD -w $PWD -e UPLOAD_CHANNEL -e CU_VERSION "${image_name}" .circleci/unittest/linux/scripts/install.sh | |||
| - run: | |||
| name: Run tests | |||
| command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh | |||
| command: docker run -e CIRCLECI -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh | |||
There was a problem hiding this comment.
Since we're using docker run, we have to add that so that the docker container knows about the CIRCLECI env variable (set by CircleCI).
We do that in a bunch of places already.
A more robust version will be to maybe use the BASH_ENV variable, or to dump env into a file and source it in the container. We'll have to do that soon enough when we expand the cpu_and_gpu() to also work with CircleCI, but for now this is good enough as only the linux_gpu job needs CIRCLECI ATM
|
The test is (finally!!) properly skipped in unittest_linux_gpu so I'll merge. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2021
Reviewed By: datumbox Differential Revision: D28473320 fbshipit-source-id: 8ecc3772e63f79343cce18e68ab5516f7e841710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily skips some failing tests as suggested in #3702 (comment)