Pin JPEG version to resolve the size_t issue on windows #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with the root issue here: is this something we should expect to be fixed eventually by libjpeg? Do we have a plan to remove the pinning? If yes, LGTM 😄 |
|
Yes, this should be a short-term solution (see discussion at #3777 (comment)). If it's not fixed, we will introduce a type alias that will vary from platform to platform or look for an alternative solution... |
|
Thanks @datumbox |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2021
Reviewed By: datumbox Differential Revision: D28473328 fbshipit-source-id: 8ef20cd016b5fd0ac0441358d43db7009f01fa18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3775