Fix io docs and expose ImageReadMode in torchvision.io
#3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oke-aditya
changed the title
ImageReadMode in torchvision.io
oke-aditya
changed the title
ImageReadMode in torchvision.ioImageReadMode in torchvision.io
datumbox
approved these changes
May 11, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
May 19, 2021
…3812) Summary: * Fix io imports and expose methods * fix fmt Reviewed By: cpuhrsch Differential Revision: D28538767 fbshipit-source-id: 7e7d11f0267dfcf3e30196256951e732925902b1 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
ImageReadModeshould be exposed totorchvision.io.ImageReadModeSince we exposed the methods such as
decode_jpeg,decode_png,read_file,write_flein__init__I exposed docs for them.I think if they are private methods then probably they shouldn't have been exposed in
__init__and also be named with_.Also small nits to docs.
Let me know if changes are need !
cc @datumbox