Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FBcode->GH] Added dataset download support in fbcode (#3823) #3826

Merged
merged 1 commit into from
May 13, 2021
Merged

[FBcode->GH] Added dataset download support in fbcode (#3823) #3826

merged 1 commit into from
May 13, 2021

Conversation

prabhat00155
Copy link
Contributor

Summary:
Pull Request resolved: #3823

Uploaded FashionMNIST dataset to manifold bucket torchvision. Any new dataset that needs to be added could be uploaded under tree/datasets/<dataset_name>.

Reviewed By: datumbox

Differential Revision: D28358470

fbshipit-source-id: 6f2282d3f1ce4b1416e962de8fb132896d4b2d76

@prabhat00155
Added dataset download support in fbcode (pytorch#3823)
301a22d 
Summary:
Pull Request resolved: pytorch#3823

Uploaded FashionMNIST dataset to [manifold](https://www.internalfb.com/intern/network/manifold/?bucket=torchvision&path=tree%2Fdatasets) bucket `torchvision`. Any new dataset that needs to be added could be uploaded under `tree/datasets/<dataset_name>`.

Reviewed By: datumbox

Differential Revision: D28358470

fbshipit-source-id: 6f2282d3f1ce4b1416e962de8fb132896d4b2d76
@prabhat00155 prabhat00155 requested a review from datumbox May 13, 2021 15:26
datumbox
datumbox approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Prabhat!

@prabhat00155 prabhat00155 merged commit f5aa5f5 into pytorch:master May 13, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/datasets_fbcode branch May 13, 2021 15:49
@NicolasHug
Copy link
Member

Just a minor note @prabhat00155 : you did well by prefixing the PR title with [FBcode->GH], but the prefix was missing in the commit message, where it actually matters, ;) https://github.com/pytorch/vision/commits/fbsync

@prabhat00155
Copy link
Contributor Author

Just a minor note @prabhat00155 : you did well by prefixing the PR title with [FBcode->GH], but the prefix was missing in the commit message, where it actually matters, ;) https://github.com/pytorch/vision/commits/fbsync

Thanks, will keep that in mind next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prabhat00155 @NicolasHug @datumbox @facebook-github-bot