Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing #3805: remove deprecated function call #3858

Merged
merged 2 commits into from
May 21, 2021

Conversation

bjuncek
Copy link
Contributor

@bjuncek bjuncek commented May 19, 2021

Re: #3805

split in multiple PRs to make assesing FBCode compatibility easier for @prabhat00155

@fmassa
Copy link
Member

fmassa commented May 19, 2021

@prabhat00155 can you try importing this PR and see if everything goes smootlhy in fbcode before we merge the PR?

Copy link
Contributor

@prabhat00155 prabhat00155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@prabhat00155 prabhat00155 merged commit 1a10a9a into pytorch:master May 21, 2021
facebook-github-bot pushed a commit that referenced this pull request May 25, 2021
Summary: Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

Reviewed By: vincentqb, cpuhrsch

Differential Revision: D28679975

fbshipit-source-id: 532406fb8a8f105e550c1942ff9fbda73d50b9c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants