Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make target argument in transform.py truly optional #3866

Merged
merged 1 commit into from
May 20, 2021
Merged

Make target argument in transform.py truly optional #3866

merged 1 commit into from
May 20, 2021

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented May 20, 2021 •
edited
Loading

Hi @datumbox

I found that some target arguments didn't set to a default value None when its type are specified as Optional.

datumbox
datumbox approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhiqwang!

@datumbox datumbox merged commit b060163 into pytorch:master May 20, 2021
@zhiqwang zhiqwang deleted the make-target-optional branch May 20, 2021 17:33
facebook-github-bot pushed a commit that referenced this pull request May 25, 2021
@datumbox @facebook-github-bot
[fbsync] Make target argument in transform.py truly optional (#3866)
7a6699e 
Reviewed By: vincentqb, cpuhrsch

Differential Revision: D28677151

fbshipit-source-id: 246eff17a3a6e018c44a52e47ab902907871334f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqwang @datumbox @facebook-github-bot