Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new assert_equal test util based on torch.testing.assert_close #3872

Merged
merged 24 commits into from
May 21, 2021
Merged

Add new assert_equal test util based on torch.testing.assert_close #3872

merged 24 commits into from
May 21, 2021

Conversation

NicolasHug
Copy link
Member

We're splitting #3865 into multiple sub-PRs to ease reviewing.

This is the first one of them and we need it to be merged first as this util will be used in the rest

pmeier and others added 23 commits May 20, 2021 14:09
@pmeier
adopt torch.testing.assert_close in test suite
c4fc01b
@pmeier
revert some changes
bfbe19b
@pmeier
add todo
09f86f4
@pmeier
flake8
86402f0
@NicolasHug
Hopefully fixed test_functional_tensor
48d32e6
@NicolasHug
hopefully fixed test_ops
15b50e3
@NicolasHug
Merge branch 'master' of github.com:pytorch/vision into assert-close
a54880f
@NicolasHug
Fix test_utils
61874ac
@NicolasHug
revert unwanted changes to test_image
30f20a3
@NicolasHug
maybe fixed test_transforms
3a29ae3
@NicolasHug
Merge branch 'master' into assert-close
d6d73d0
@pmeier
fix test_datasets_video_utils
863f144
@pmeier
fix test_transforms
c8a5afa
@pmeier
Merge branch 'master' into assert-close
e697e88
@pmeier
flake8
93614f0
@NicolasHug
Merge branch 'master' of github.com:pytorch/vision into assert-close
11caf01
@NicolasHug
Merge branch 'assert-close' of github.com:pmeier/vision into assert-c…
d7fde8c 
…lose
@NicolasHug
use cu102 see if the nightlies are actual nightlies?
0b237c7
@NicolasHug
obviously forgot to call regenerate.py
c2ace86
@NicolasHug
not as obvious, reverting
d78226a
@NicolasHug
Merge branch 'master' into assert-close
bb543a7
@NicolasHug
Merge branch 'master' of github.com:pytorch/vision into assert-close
48b47be
@NicolasHug
revert everything except for assert_equal
d2eeaaa
datumbox
datumbox approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasHug NicolasHug merged commit 89cb908 into pytorch:master May 21, 2021
@NicolasHug
Copy link
Member Author

NicolasHug commented May 21, 2021 •
edited
Loading

Thanks!
I'll merge now without waiting for the CI. There's no new test anyway and #3865 shows that now that the latest nightlies are properly picked up, torch.testing.assert_close is properly discovered by all CI jobs

facebook-github-bot pushed a commit that referenced this pull request May 25, 2021
@datumbox @facebook-github-bot
[fbsync] Add new assert_equal test util based on torch.testing.assert…
fdaa46c 
…_close (#3872)

Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de>

Reviewed By: vincentqb, cpuhrsch

Differential Revision: D28679980

fbshipit-source-id: 7fe453c40e375a12a908dbb4ac42263755f2f8c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @datumbox @facebook-github-bot @pmeier