Port group H test_transforms.py to pytest #3964
Conversation
|
Hi @vivekkumar7089! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Thanks @vivekkumar7089 !
Looks like there's a flake8 issue:
./test/test_transforms.py:407:5: E303 too many blank lines (2)
but apart from that the changes look good to me if CI goes green
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It was a very minor flake8 issue so I fixed it myself so we can merge and move forward. Thanks a lot @vivekkumar7089 ! |
|
Thnx a lot @NicolasHug !! |
Reviewed By: NicolasHug Differential Revision: D29027338 fbshipit-source-id: d37aac6510b296eac9b32ff8e960088e978ab8b6
Refactor Group H as mentioned in #3945
test_random_apply
test_random_choice
test_random_order