Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'range' in docstrings of 'normalize' to 'value_range'. #3967

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Change 'range' in docstrings of 'normalize' to 'value_range'. #3967

merged 2 commits into from
Jun 4, 2021

Conversation

njuaplusplus
Copy link
Contributor

Change range in docstrings of normalize to value_range.

The current docstring for 'normalize' is:

normalize (bool, optional): If True, shift the image to the range (0, 1),  by the min and max values specified by :attr:`range`. Default: ``False``.

However, the parameter range has been changed to value_range.

@njuaplusplus
fix docstrings
5432489 
Change range to value_range
@facebook-github-bot
Copy link

Hi @njuaplusplus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@NicolasHug NicolasHug mentioned this pull request Jun 4, 2021
Closed
NicolasHug
NicolasHug approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuaplusplus ! LGTM with a minor suggestion

torchvision/utils.py Outdated Show resolved Hide resolved
@njuaplusplus @NicolasHug
Update docstrings
820005f 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@NicolasHug NicolasHug merged commit a0b44d7 into pytorch:master Jun 4, 2021
@NicolasHug
Copy link
Member

Thanks for the fix @njuaplusplus !

@njuaplusplus
Copy link
Contributor Author

Thanks for the fix @njuaplusplus !

Thank you very much! @NicolasHug

facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2021
@fmassa @facebook-github-bot
[fbsync] Change 'range' in docstrings of make_grid to 'value_range' (#…
a8f4649 
…3967)

Reviewed By: NicolasHug

Differential Revision: D29027296

fbshipit-source-id: 044516749037305a5815735ffa067df3ac680661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation module: utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njuaplusplus @facebook-github-bot @NicolasHug