Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port some test_random_xxx in test_transforms to pytest #3972

Merged
merged 8 commits into from
Jun 5, 2021
Merged

Port some test_random_xxx in test_transforms to pytest #3972

merged 8 commits into from
Jun 5, 2021

Conversation

AnirudhDagar
Copy link
Contributor

Port Group I as mentioned in #3945.

  • test_random_crop
  • test_random_erasing
  • test_random_rotation
  • test_randomperspective
  • test_randomperspective_fill

AnirudhDagar
AnirudhDagar commented Jun 5, 2021
View reviewed changes
test/test_transforms.py Outdated Show resolved Hide resolved
test/test_transforms.py Outdated Show resolved Hide resolved
@sahilg06
Copy link
Contributor

sahilg06 commented Jun 5, 2021 •
edited
Loading

@AnirudhDagar This may help #3945 (comment)

@AnirudhDagar
Copy link
Contributor Author

Thanks a lot @sahilg06! :)

NicolasHug
NicolasHug approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @AnirudhDagar ! Minor comment but LGTM when addressed

test/test_transforms.py Outdated Show resolved Hide resolved
test/test_transforms.py Show resolved Hide resolved
@NicolasHug NicolasHug mentioned this pull request Jun 5, 2021
Closed
16 tasks
@NicolasHug
Copy link
Member

lol sorry about the many syncs @AnirudhDagar , I've just been merging a bunch of PRs in master and they create conflicts.
Let me take care of this last one and I'll merge the PR - CI were green (with unrelated jobs failing) so that's fine

@NicolasHug NicolasHug merged commit 453dd2e into pytorch:master Jun 5, 2021
@NicolasHug
Copy link
Member

Merging, thanks again!

@AnirudhDagar
Copy link
Contributor Author

Haha, no worries! Thank you so much for guiding me through this :))
Hoping to contribute more very soon.

@AnirudhDagar AnirudhDagar deleted the refactor-test-random_xxx branch June 5, 2021 11:33
facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2021
@fmassa @facebook-github-bot
[fbsync] Port some test_random_xxx in test_transforms to pytest (#3972)
7e05cf2 
Reviewed By: NicolasHug

Differential Revision: D29027328

fbshipit-source-id: eb7a58c5a5985f105f6b7b5a7c33760cadb9723f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnirudhDagar @sahilg06 @NicolasHug @facebook-github-bot