port pad, resized_crop and affine in test_functional_tensor to pytest #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
NicolasHug
reviewed
Jun 5, 2021
There was a problem hiding this comment.
Thanks a lot @saswatpp , excellent work on test_affine! You made a lot of sensible choices. I made a few minor comments but this looks great already
NicolasHug
reviewed
Jun 5, 2021
NicolasHug
approved these changes
Jun 6, 2021
4 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
…nsor to pytest (#3974) Reviewed By: NicolasHug Differential Revision: D29027355 fbshipit-source-id: fb8f8d30b2fcb99c028073b8d26e9975369403e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the following tests to
pytestin the file test/test/functional_tensor.py mentioned in the issue #3956Group B2 :
test_pad-- parametrized device,dt,pad,configtest_resized_crop-parametrized device, modeGroup C :
TestAffinetest_batchestest_warnings@NicolasHug, this one was definitely tricky as you mentioned and I hope the above design makes sense :)