Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] mypy install missing stubs #4014

Merged
merged 9 commits into from
Jun 9, 2021
Merged

[CI] mypy install missing stubs #4014

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
59f0cc0
[CI] mypy install missing stubs
AnirudhDagar Jun 9, 2021
cb22a6a
make the commands ordering consistent
AnirudhDagar Jun 9, 2021
cfb1636
[CI] update config.yml.in for mypy --install-types
AnirudhDagar Jun 9, 2021
0d18aec
revert #4011: remove type check ignore
AnirudhDagar Jun 9, 2021
2d6c3e6
Merge branch 'master' into fix-mypy
AnirudhDagar Jun 9, 2021
79a912d
automatically proceed with yes for mypy --install-types
AnirudhDagar Jun 9, 2021
9504fdf
wait for mypy --install-types before type checks
AnirudhDagar Jun 9, 2021
6ab6d4e
install types-requests specifically
AnirudhDagar Jun 9, 2021
dcb1343
Merge branch 'master' into fix-mypy
NicolasHug Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ jobs:
pip install --user --progress-bar off mypy
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
pip install --user --progress-bar off --editable .
mypy --install-types
AnirudhDagar marked this conversation as resolved.
Show resolved Hide resolved
mypy --config-file mypy.ini

docstring_parameters_sync:
Expand Down
1 change: 1 addition & 0 deletions .circleci/config.yml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ jobs:
pip install --user --progress-bar off mypy
pip install --user --progress-bar off --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
pip install --user --progress-bar off --editable .
mypy --install-types
mypy --config-file mypy.ini

docstring_parameters_sync:
Expand Down
2 changes: 1 addition & 1 deletion torchvision/datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def download_file_from_google_drive(file_id: str, root: str, filename: Optional[
md5 (str, optional): MD5 checksum of the download. If None, do not check
"""
# Based on https://stackoverflow.com/questions/38511444/python-download-files-from-google-drive-using-url
import requests # type: ignore
import requests
url = "https://docs.google.com/uc?export=download"

root = os.path.expanduser(root)
Expand Down