Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop virtual from private member functions of Decoder class #4027

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Drop virtual from private member functions of Decoder class #4027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f607c
Drop virtual from private member functions of Decoder class
prabhat00155 Jun 9, 2021
b16f8cf
Merge branch 'master' into prabhat00155/fix_seg_fault
prabhat00155 Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions torchvision/csrc/io/decoder/decoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ class Decoder : public MediaDecoder {

private:
// mark below function for a proper invocation
virtual bool enableLogLevel(int level) const;
virtual void logCallback(int level, const std::string& message);
virtual int readCallback(uint8_t* buf, int size);
virtual int64_t seekCallback(int64_t offset, int whence);
virtual int shutdownCallback();
bool enableLogLevel(int level) const;
void logCallback(int level, const std::string& message);
int readCallback(uint8_t* buf, int size);
int64_t seekCallback(int64_t offset, int whence);
int shutdownCallback();

bool openStreams(std::vector<DecoderMetadata>* metadata);
Stream* findByIndex(int streamIndex) const;
Expand Down