Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning message for unsupported ffmpeg version #4041

Merged
merged 5 commits into from
Jun 11, 2021
Merged

Added warning message for unsupported ffmpeg version #4041

merged 5 commits into from
Jun 11, 2021

Conversation

prabhat00155
Copy link
Contributor

Resolves #4022.

datumbox
datumbox approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I just left a small nit.

datumbox
datumbox reviewed Jun 11, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@prabhat00155 prabhat00155 merged commit cd18188 into pytorch:master Jun 11, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/ffmpeg_version_check branch June 11, 2021 23:18
@github-actions
Copy link

Hey @datumbox, @prabhat00155!

You approved or merged this PR, but no labels were added.

@prabhat00155
Copy link
Contributor Author

Hey @datumbox, @prabhat00155!

You approved or merged this PR, but no labels were added.

@NicolasHug, @datumbox , @fmassa I see labels in this PR, what is this talking about?

@datumbox
Copy link
Contributor

You need to put one of the "module" labels or bug/improvement/new feature, etc. I think we should document the process a bit better because I understand now it's a bit confusing. :)

@prabhat00155
Copy link
Contributor Author

You need to put one of the "module" labels or bug/improvement/new feature, etc. I think we should document the process a bit better because I understand now it's a bit confusing. :)

Okay, thank you!

@prabhat00155 prabhat00155 mentioned this pull request Jun 12, 2021
Merged
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
@NicolasHug @facebook-github-bot
[fbsync] Added warning message for unsupported ffmpeg version (#4041)
7b21f69 
Summary:
* Added warning message for unsupported ffmpeg version

* Replaced os.popen with subprocess.run

* Removed capture_true argument

Reviewed By: fmassa

Differential Revision: D29097707

fbshipit-source-id: 775eae7ba0004462be80eaed232f75a6336ad107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: video topic: build version incompatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display warning message when building torchvision with incompatible ffmpeg version
3 participants
@prabhat00155 @datumbox @facebook-github-bot