Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test_models_detection_negative_samples.py to pytest #4045

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Port test_models_detection_negative_samples.py to pytest #4045

merged 3 commits into from
Jun 11, 2021

Conversation

zhiqwang
Copy link
Contributor

@zhiqwang zhiqwang commented Jun 11, 2021 •
edited
Loading

Port test_models_detection_negative_samples.py to pytest. Check #4033 for more details.

cc @NicolasHug

NicolasHug
NicolasHug approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhiqwang !

@NicolasHug NicolasHug merged commit 7dc8a69 into pytorch:master Jun 11, 2021
@NicolasHug NicolasHug mentioned this pull request Jun 11, 2021
Closed
8 tasks
@zhiqwang zhiqwang deleted the port-test-negative-samples branch June 11, 2021 10:35
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2021
@NicolasHug @facebook-github-bot
[fbsync] Port test_models_detection_negative_samples.py to pytest (#4045
51140b9 
)

Reviewed By: fmassa

Differential Revision: D29097729

fbshipit-source-id: cd98bcfa09428b1662486d3739eb9d883e6f8a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: models module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqwang @NicolasHug @facebook-github-bot