Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dataset added (Caltech-UCSD Birds 200) regarding issue #147 #60829 #4126

Closed
wants to merge 1 commit into from

Conversation

shakeebmurtaza
Copy link

A new dataset added (Caltech-UCSD Birds 200) regarding issue #147 #60829.

A lot of people are using Caltech-UCSD Birds-200-2011 dataset for the evaluation of their proposed models. According to paperswithcode.com 787 papers employed this dataset since 2017 and these numbers are growing. So, I want to add support for this data in the datasets library.

@vadimkantorov
Copy link

Some problems with the previous version was that there are multiple setups of using CUB and its metadata.

The typical metric learning setup defines some class splits.

Considering metadata, there is a bbox crop for every image and attributes. At least it should be available for retrieval via index. At most, maybe there should be an option that always does the crop in the dataset (I think often it's what people do in metric learning evaluation)

So it may be best to also define more specific Cub2011MetricLearningDataset-like classes after ensuring what exactly is the standard practice in metric learning pipelines.

@datumbox datumbox requested a review from pmeier June 28, 2021 12:03
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shakeebmurtaza and thanks for the PR! Although this was proposed in #3562 as potential new dataset, AFAIK we never reached a conclusion. @fmassa, are we going to move forward with this, or do we wait with adding new datasets until after the rework?

@shakeebmurtaza
Copy link
Author

shakeebmurtaza commented Jul 1, 2021

Hey, @pmeier and @fmassa. Any update regarding this issue. If your response is positive then I need to do some quick fixes.

@pmeier
Copy link
Collaborator

pmeier commented Jul 2, 2021

@shakeebmurtaza we need to be patient for a little longer. I assume we get an answer mid next week.

@frgfm frgfm mentioned this pull request Jul 29, 2021
@pmeier
Copy link
Collaborator

pmeier commented Mar 24, 2022

In #5154 we added this to the new prototype datasets.

@pmeier pmeier closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants