Mock redirection logic for tests #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jul 21, 2021
There was a problem hiding this comment.
Thanks @pmeier , looks good, I'm trying to see if we could simplify things a bit :)
NicolasHug
reviewed
Jul 21, 2021
|
BTW now that these tests don't require an internet connection, we can take them away from this file and put back where they were prior to #4032 :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
Summary: * mock out redirect behavior for testing * revert unrelated change * simplify * move tests out of internet tests * replace urls with dummys * improve checking of mock calls Reviewed By: fmassa Differential Revision: D29932698 fbshipit-source-id: b7d87bc50407e7916d6f4f87bd0cbcd2a8db2214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recent CI failures like this. Two of our tests depend on the Caltech servers, which are down for some days #4188. This PR removes the dependency and mocks out the redirection behavior.