-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing typing annotations to transforms/functional_tensor #4236
Conversation
Oh! I too had a shot at this have a look at #4235. |
Oh shoot, my bad, I thought I had checked that you hadn't taken care of this one 🙃 |
@fmassa I checked locally by removing the mypy ignore from |
Thanks @frgfm , could you please remove it in this PR as well, so that we can rely on the CI to check the file? |
I would have done it, but there are other files handled by other PRs in |
Yes, we should remove the global ignore of
|
I just added other files that were throwing typing errors 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Ready to be merged @fmassa :) |
Hey @datumbox! You merged this PR, but no labels were added. |
…nsor (#4236) Summary: * style: Added missing typing annotations * style: Fixed typing * style: Fixed typing * chore: Updated mypy.ini Reviewed By: NicolasHug Differential Revision: D30417193 fbshipit-source-id: 0d0b75c78513e86bd62d13e717d14086fba0916f Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Following up on #2025, this PR adds missing typing annotations in transforms/functional_tensor.py. I checked locally by editing the mypy.ini and everything looks good 👍
Any feedback is welcome!