ffmpeg version query #4254
Merged
ffmpeg version query #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Aug 5, 2021
setup.py
Outdated
| stdout=subprocess.PIPE).stdout.decode('utf-8') | ||
| ffmpeg_version = ffmpeg_version.split('version')[-1].split()[0] | ||
| ffmpeg_version_str = str(subprocess.check_output(["ffmpeg", "-version"])) | ||
| ffmpeg_version = re.split(r"ffmpeg\ version\ |\.|\ |-", ffmpeg_version_str)[1:3] |
There was a problem hiding this comment.
Thanks @vmoens !
Do we need to escape the spaces? i.e. could this just be ffmpeg version |\.| |-?
Also, let's add a small description for future-us, something like
# this splits on both dots and spaces as the output format differs across versions / platforms
There was a problem hiding this comment.
@vmoens do we still need to espace the spaces? Other than that, LGTM :)
There was a problem hiding this comment.
I thought i corrected that, but you're right there are a couple remaining
NicolasHug
approved these changes
Aug 6, 2021
|
Hey @vmoens! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Summary: * string manipulation for ffmpeg version retrieval * ffmpeg version 4.2 control * commenting solution * removing all escapes for spaces Reviewed By: NicolasHug Differential Revision: D30417202 fbshipit-source-id: 1e685d810eae1d1887b06586c8142e87ee4a1b4b Co-authored-by: Vincent Moens <vmoens@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4214