Overwrite the existing dlls while unzipping #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszhanyi
changed the title
|
@malfet @NicolasHug There're only 3 mac workflows failure. I think it's a known issue and has nothing with this PR |
|
For 10.2, if the dlls are not overwrited. As mentioned in #4058 (comment) I'll make the copying logic only for 10.2 in another PR. |
malfet
approved these changes
Sep 13, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: * if there's dll, overwrite it * temp change * revert last Reviewed By: datumbox Differential Revision: D31268060 fbshipit-source-id: 6e70e867268ce0786c198aec23ce4ec99b9c0014 Co-authored-by: Nikita Shulga <nshulga@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vision, the build & test are running on Windows GPU machines.
So far, The default cuda driver is 10.1 in circleCI image.
So there's alreay gpu_driver_dlls, we should allow the old dlls could be overwrited by the downloaded dlls(10.2).
Else, there's the error
https://app.circleci.com/pipelines/github/pytorch/vision/10311/workflows/c0f4755c-4254-40cd-ad67-418617a7817f/jobs/781019
cc @seemethere