Skip building torchvision with ffmpeg when python==3.9 #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Thank you @prabhat00155 , I think this is indeed the safest option for now. LGTM. Do you think we should reopen #3367?
NicolasHug
reviewed
Sep 16, 2021
|
One thing it would be good to understand is why only Python 3.9 is failing. IIUC the python version has no influence on the ffmpeg version we are installing, so maybe this is an issue with our binding code (torchbind?) |
Yeah, makes sense. I've created this issue: #4430 to track this, will debug this further. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: * Skip building torchvision with ffmpeg when python==3.9 * Add FIXME to comments Reviewed By: datumbox Differential Revision: D31268057 fbshipit-source-id: 71d3ee6c2e0f5cc373bf730804e1d5172a2d6a9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building torchvision with ffmpeg 4.3 causes seg fault with python 3.9. Initial debugging shows crash in ffmpeg's sws_scale(). Until this issue is resolved, it's better to avoid building torchvision with ffmpeg for python 3.9.
cc @pmeier