enable windows cuda unit tests #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszhanyi
requested review from
malfet,
seemethere and
NicolasHug
and removed request for
malfet
…/enableunittest
mszhanyi
changed the title
|
verified. @malfet
|
|
@NicolasHug |
|
@NicolasHug @fmassa |
|
@mszhanyi if the |
…/enableunittest
This reverts commit 1ce58c5.
|
All tests passed by rerunning but Workflow: build & Workflow: unittest status not updated |
malfet
reviewed
Sep 29, 2021
malfet
approved these changes
Sep 29, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: * enable cuda for unittest * add one check * rename * minor fix * add more check * add cuda envs * add more cuda envs * add driver update * update vs integration * get cuda version * merge * add envs in install.sh * reduce some change and add comments * minor improve * fix typo * exit if driver update failed * fix lint * fix lint * Avoid catching exception to show error message * try 11.1 * try 11.1 * "try 11.1" * set the downloaded gpu driver dlls only for 10.2 * check torch.cuda.is_available() * add display.driver * Revert "Avoid catching exception to show error message" This reverts commit 1ce58c5. * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh Reviewed By: datumbox Differential Revision: D31268020 fbshipit-source-id: a940a56ac02a5e440f4cbf8fc4b199e429c9002d Co-authored-by: Nicolas Hug <nicolashug@fb.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com> Co-authored-by: Nikita Shulga <nshulga@fb.com>
malfet
added a commit
that referenced
this pull request
Oct 22, 2021
GPU tests have special step to install the driver, CUDA install step shouldl just install the runtime never Fixes regression introduced by #4421
malfet
added a commit
that referenced
this pull request
Oct 22, 2021
GPU tests have special step to install the driver, CUDA install step shouldl just install the runtime never Fixes regression introduced by #4421
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
Summary: GPU tests have special step to install the driver, CUDA install step shouldl just install the runtime never Fixes regression introduced by #4421 Reviewed By: NicolasHug Differential Revision: D31916340 fbshipit-source-id: 700b522fcfe58942603f8eb336811c585c28330e
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* enable cuda for unittest * add one check * rename * minor fix * add more check * add cuda envs * add more cuda envs * add driver update * update vs integration * get cuda version * merge * add envs in install.sh * reduce some change and add comments * minor improve * fix typo * exit if driver update failed * fix lint * fix lint * Avoid catching exception to show error message * try 11.1 * try 11.1 * "try 11.1" * set the downloaded gpu driver dlls only for 10.2 * check torch.cuda.is_available() * add display.driver * Revert "Avoid catching exception to show error message" This reverts commit 1ce58c5. * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh * Update .circleci/unittest/windows/scripts/set_cuda_envs.sh Co-authored-by: Nicolas Hug <nicolashug@fb.com> Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com> Co-authored-by: Nikita Shulga <nshulga@fb.com>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
GPU tests have special step to install the driver, CUDA install step shouldl just install the runtime never Fixes regression introduced by pytorch#4421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for unittest_windows_GPU
add nvjpeg in cuda_install
add cuda_install step in unittest_windows_gpu workflow
add cuda driver update step in unittest_windows_gpu workflow
CUDA Runtime , CUDA Driver and CUDA Environments are all necessary to run cuda tests.
It's hard to submit individual PRs.
cc @seemethere