Conda: Add numpy dependency #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import torchvision` fails if numpy is not installed, so it should have an explicit dependency on it (which is already the case for wheel package)
janeyx99
approved these changes
Sep 17, 2021
driazati
approved these changes
Sep 17, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: `import torchvision` fails if numpy is not installed, so it should have an explicit dependency on it (which is already the case for wheel package) Reviewed By: datumbox Differential Revision: D31268052 fbshipit-source-id: a24cb001775a6a6dba8a371c48fa6e37671ee949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import torchvisionfails if numpy is not installed, so it should havean explicit dependency on it (which is already the case for wheel
package)