Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite gallery example for masks to boxes. #4484

Merged
merged 10 commits into from
Sep 29, 2021

Conversation

oke-aditya
Copy link
Contributor

Not done yet, I will ping once it's ready for review.

@oke-aditya oke-aditya changed the title [WIP] Rewrite gallery example. [WIP] Rewrite gallery example for masks to boxes. Sep 25, 2021
@oke-aditya oke-aditya marked this pull request as ready for review September 27, 2021 16:11
@oke-aditya oke-aditya changed the title [WIP] Rewrite gallery example for masks to boxes. Rewrite gallery example for masks to boxes. Sep 27, 2021
@oke-aditya
Copy link
Contributor Author

oke-aditya commented Sep 27, 2021

I think I have completed it. Now the tutorial includes converting masks to boxes and

  1. torchvision.io to read images and masks.
  2. Plotting masks and boxes using torchvision.utils
  3. Using FasterRCNN over converted boxes.
  4. A simple SegmentationToDetection dataset

Feel free to review @NicolasHug @0x00b1 @datumbox

@NicolasHug
Copy link
Member

thanks @oke-aditya , I'll take a look tomorrow

@oke-aditya
Copy link
Contributor Author

oke-aditya commented Sep 27, 2021

Here is the link to rendered example 😄

https://822905-73328905-gh.circle-artifacts.com/0/docs/auto_examples/plot_repurposing_annotations.html#

P.S. Please take care of grammar and english. Mine is bit Indian flavoured 😄 🇮🇳

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oke-aditya , I made a few minor comments but this looks great.

Since the example currently only shows how to repurpose masks into bounding boxes, should we change the title of the example to

"Repurposing masks into bounding boxes"

?

I feel like this would be more specific and perhaps more enticing for the reader? We could always change the title later when we add more stuff (we can keep the file name as is)

gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
@oke-aditya
Copy link
Contributor Author

Hi @NicolasHug feel free to have a review.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oke-aditya , I made another pass with minor suggestions, LGTM when addressed :)

gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
gallery/plot_repurposing_annotations.py Outdated Show resolved Hide resolved
@oke-aditya
Copy link
Contributor Author

Hey @NicolasHug two small things to clear, then we would be good to merge.

@oke-aditya
Copy link
Contributor Author

We should be good to merge!! @NicolasHug

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @oke-aditya !!
LGTM, I'll merge tomorrow after checking the rendered docs :)

@oke-aditya
Copy link
Contributor Author

@NicolasHug NicolasHug merged commit a9d710a into pytorch:main Sep 29, 2021
@NicolasHug
Copy link
Member

Thanks again @oke-aditya !!

@oke-aditya oke-aditya deleted the add_exmpl branch September 29, 2021 07:51
@oke-aditya
Copy link
Contributor Author

I learn a lot by contributing. Thanks to you guys. 😀

facebook-github-bot pushed a commit that referenced this pull request Sep 30, 2021
Summary:
* start writing example

* Update example

* Add PenFudan Files

* Update example

* Remove unused files

* Update file and adopt changes

* Create links, fix float

Reviewed By: datumbox

Differential Revision: D31268018

fbshipit-source-id: 71d7f78139ca91334ff2776efd220de31e94eeaf

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
* start writing example

* Update example

* Add PenFudan Files

* Update example

* Remove unused files

* Update file and adopt changes

* Create links, fix float

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants