-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite gallery example for masks to boxes. #4484
Conversation
I think I have completed it. Now the tutorial includes converting masks to boxes and
Feel free to review @NicolasHug @0x00b1 @datumbox |
thanks @oke-aditya , I'll take a look tomorrow |
Here is the link to rendered example 😄 P.S. Please take care of grammar and english. Mine is bit Indian flavoured 😄 🇮🇳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oke-aditya , I made a few minor comments but this looks great.
Since the example currently only shows how to repurpose masks into bounding boxes, should we change the title of the example to
"Repurposing masks into bounding boxes"
?
I feel like this would be more specific and perhaps more enticing for the reader? We could always change the title later when we add more stuff (we can keep the file name as is)
Hi @NicolasHug feel free to have a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oke-aditya , I made another pass with minor suggestions, LGTM when addressed :)
Hey @NicolasHug two small things to clear, then we would be good to merge. |
We should be good to merge!! @NicolasHug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @oke-aditya !!
LGTM, I'll merge tomorrow after checking the rendered docs :)
Here is the link for final docs. 😃 |
Thanks again @oke-aditya !! |
I learn a lot by contributing. Thanks to you guys. 😀 |
Summary: * start writing example * Update example * Add PenFudan Files * Update example * Remove unused files * Update file and adopt changes * Create links, fix float Reviewed By: datumbox Differential Revision: D31268018 fbshipit-source-id: 71d7f78139ca91334ff2776efd220de31e94eeaf Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
* start writing example * Update example * Add PenFudan Files * Update example * Remove unused files * Update file and adopt changes * Create links, fix float Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Not done yet, I will ping once it's ready for review.