Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable Shuffler in Caltech prototype #4517

Merged
merged 2 commits into from
Oct 1, 2021
Merged

enable Shuffler in Caltech prototype #4517

merged 2 commits into from
Oct 1, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 1, 2021 •
edited by pytorch-probot bot
Loading

datumbox
datumbox approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Phillip.

The failing test is flaky and unrelated. I restarted it again, we can merge once CI is green.

@datumbox datumbox merged commit 05d7651 into pytorch:main Oct 1, 2021
@pmeier pmeier deleted the datasets/fix-caltech branch October 1, 2021 11:53
facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2021
@NicolasHug @facebook-github-bot
[fbsync] enable Shuffler in Caltech prototype (#4517)
4232ee4 
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: kazhang

Differential Revision: D31337426

fbshipit-source-id: 95eed51c120dc8a6c1afdb4ac3c07c5efb73e9e8
mszhanyi pushed a commit to mszhanyi/vision that referenced this pull request Oct 19, 2021
@pmeier @datumbox @mszhanyi
enable Shuffler in Caltech prototype (pytorch#4517)
1397a9e 
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
@pmeier @datumbox @cyyever
enable Shuffler in Caltech prototype (pytorch#4517)
866d473 
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed module: datasets prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @datumbox @facebook-github-bot