Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Workaround for loading bundled DLLs #4893

Merged
merged 5 commits into from
Dec 13, 2021
Merged

[Windows] Workaround for loading bundled DLLs #4893

merged 5 commits into from
Dec 13, 2021

Commits on Dec 13, 2021

  1. [Windows] Workaround for loading bundled DLLs 

    Python-3.8+ adds `add_dll_directory` call, see https://docs.python.org/3/whatsnew/3.8.html#ctypes
Simulate this behaviour on older versions of Python runtime by calling
`LoadLibraryExW` with the appropriate flags

Fixes #4787
    @malfet
    malfet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9806ba3 View commit details
    Browse the repository at this point in the history

  2. Address review feedback 

    Get rid of `pass`, import `os`, `sys` and `warnnings` globally, fix
`global()`->`globals()` typo
    @malfet
    malfet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    24ee977 View commit details
    Browse the repository at this point in the history

  3. More review feedback addressed

    @malfet
    malfet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b09f632 View commit details
    Browse the repository at this point in the history

  4. Move _load_library to torchvision.extension

    @malfet
    malfet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    52a6e14 View commit details
    Browse the repository at this point in the history

  5. Remove type annotations to pacify linter

    @malfet
    malfet committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a5babfb View commit details
    Browse the repository at this point in the history