Addresses issue #145 as per @fmessa's suggestion. #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
pushed a commit
to varunagrawal/vision
that referenced
this pull request
Jul 23, 2018
* Addresses issue pytorch#145 as per @fmessa's suggestion. * Removed blank line for styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes DatasetFolder more flexible by moving find_classes to DatasetFolder. See issue #145 and fmessa's comment for more information.
I tested the code using this short snippet: https://gist.github.com/Choco31415/051d6bf59b65c2347166bc5b4f956396
The test includes one using a basic DatasetFolder, and one with find_classes overridden to work with the Omniglot dataset. Not included is also a test for when the dataset is nested within a few directories.