Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shape mismatch error #5489

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

prabhat00155
Copy link
Contributor

Resolves #1884.

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 26, 2022

💊 CI failures summary and remediations

As of commit 59286fa (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 2 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox requested a review from bjuncek March 2, 2022 09:15
@bjuncek
Copy link
Contributor

bjuncek commented Apr 1, 2022

@datumbox LGTM, this partially resolves kinetics issue

@datumbox
Copy link
Contributor

datumbox commented Apr 1, 2022

@prabhat00155 @bjuncek Thanks! Have we tested the patch and confirmed it works for training?

What does partially means here?

@prabhat00155
Copy link
Contributor Author

@bjuncek Were you able to test this on your setup?

@bjuncek
Copy link
Contributor

bjuncek commented Apr 1, 2022

So on my system that resolves dataset generation issue, but probably does not resolve accuracy issue (I can't test this due to only having one gpu).

@datumbox datumbox merged commit b7c59a0 into pytorch:main Apr 1, 2022
@prabhat00155 prabhat00155 deleted the prabhat00155/fix_shape_error branch April 1, 2022 17:17
facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
Summary:
* Fix shape mismatch error

* Update offset

Reviewed By: NicolasHug

Differential Revision: D35393160

fbshipit-source-id: 53cf620487691d5aac2baac48508b2f620003108

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoClips Assertion Error
4 participants