Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.11 #6841

Closed
wants to merge 11 commits into from
Closed

Add Python 3.11 #6841

wants to merge 11 commits into from

Conversation

alihassanijr
Copy link

This PR adds Python 3.11 (cp311) to the CircleCI regenerate script, and the package helper.

I noticed torch 1.13 is built with cp311 wheels, but not torchvision.
I would assume this will create issues for users on 3.11, since pip will probably fall back to an older wheel.

YosuaMichael and others added 10 commits October 4, 2022 10:49
@YosuaMichael
Removing prototype related things from release/0.14 branch (pytorch#6687
673838f 
)

* Remove test related to prototype

* Remove torchvision/prototype dir

* Remove references/depth/stereo because it depend on prototype

* Remove prototype related entries on mypy.ini

* Remove things related to prototype in pytest.ini

* clean setup.py from prototype

* Clean CI from prototype

* Remove unused expect file
@pmeier
fix example galleries in documentation (pytorch#6701)
dc6d86d 
* exclude sphinx-gallery==0.11.0

* fix CSS

* Update docs/requirements.txt
@jdsgomes
fix bug in output format for pyav (pytorch#6672) (pytorch#6703)
8762598 
* fix bug in output format for pyav

* add read from memory with constructor overload

* Revert "add read from memory with constructor overload"

This reverts commit 14cbbab.

* run ufmt
@YosuaMichael @datumbox
[bugfix] Fix the output format for VideoClips.subset (pytorch#6700) (p…
3bd6ce9 
…ytorch#6706)

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
@atalman
Test against torch RC instead of nightly. Bump build version (pytorch…
5ff802b 
…#6717)

* Test against torch RC instead of nightly

Fix prev commit

* Bump version to build against

Use UPLOAD_CHANNEL instead of hardcoding
@atalman @datumbox
Fix windows python 3.8 required dlls not found (pytorch#6715) (pytorc…
95bef27 
…h#6716)

* Fix windows python 3.8

* Update torchvision/extension.py

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update torchvision/extension.py

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
@atalman
Fix for windows and python 3.8 call to add_dll_directory (pytorch#6742)…
531a2ea 
… (pytorch#6743)
@atalman
Set correct upload channel (pytorch#6744)
f15f4e8
@atalman
Increase inactivity timeout for binary build jobs (pytorch#6746) (pyt…
5ce4506 
…orch#6747)

* Increase inactivity timeout for binary build jobs

* Fix binary build steo
@alihassanijr
Add cp311 to package helper and circleci gen script
0ff78d9
@alihassanijr alihassanijr changed the title Add cp311 to package helper and circleci gen script Add Python 3.11 Oct 27, 2022
@datumbox
Copy link
Contributor

@alihassanijr Thanks for the PR.

Adding new python versions is a bit more complex as it requires coordination with PyTorch Core and the Release engineering team. @malfet / @atalman Any thoughts on this? I would assume the addition of Python 3.11 will happen after the release?

@alihassanijr
Copy link
Author

alihassanijr commented Oct 27, 2022 •
edited
Loading

Thanks for the information @datumbox .
The only reason I started this was to avoid inconsistency with the new torch release, which does support 3.11.
I don't have access to the circleci here, but I was able to build from source on 3.11 and run the tests locally (did get 5 failures, but they were failing in torch, which I'm assuming is due to a bad early wheel that I got from PT?), and can repeat that in manylinux containers with the supported cuda builds (and cpu) as well.
Don't know if that's helpful or not given that those would probably get checked when the wheels are being built, if the decision to support 3.11 comes through.

@malfet
Copy link
Contributor

malfet commented Oct 28, 2022

Continuous Integration for TorchVision is build around Anaconda, and python-3.11 is yet not available here: https://anaconda.org/anaconda/python (and I know that it is available on CondaForge, but CondaForge builds are very unstable)

malfet
malfet requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have not realized that PR targets release/0.14 branch. As @datumbox correctly mentioned we should start with default branch and may be later will pick it for release

@alihassanijr
Copy link
Author

@malfet Thanks for the information. So you'd recommend we close this, and I reopen one with main?

@alihassanijr alihassanijr changed the base branch from release/0.14 to main November 17, 2022 23:29
@alihassanijr alihassanijr mentioned this pull request Nov 17, 2022
Closed
@alihassanijr
Copy link
Author

Closing this in favor of #6959 . Rebasing this from 0.14 is just more trouble than it's worth compared to the very minor commits.

@pmeier pmeier mentioned this pull request Dec 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet requested changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alihassanijr @datumbox @malfet @facebook-github-bot @YosuaMichael @pmeier @jdsgomes @atalman