Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shebang in setup.py #773

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Remove shebang in setup.py #773

merged 1 commit into from
Mar 6, 2019

Conversation

ocourtin
Copy link
Contributor

@ocourtin ocourtin commented Mar 2, 2019

Hi,

Related to PEP 394, some Linux distributions (at the very least Ubuntu) use 'python' interpreter name for Python 2, and 'python3' for Python 3.

As in setup.py there's a check for pillow vs pillow-simd, keeping an explicit '/usr/bin/env python' leads to search for Python 2 package, even if the install is targeted for Python 3.

So keeping the shebang, seems not only useless, but become an issue, and forbid to install torchvision with pillow-simd in Python3 env.

Thanks in advance to considering applying this PR.

Remove explicit Python interpreter name.
@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   40.99%   40.99%           
=======================================
  Files          29       29           
  Lines        2747     2747           
  Branches      432      432           
=======================================
  Hits         1126     1126           
  Misses       1542     1542           
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc4970...1d16624. Read the comment docs.

@ocourtin ocourtin changed the title Remove explicit python interpreter name in setup.py Remove shebang in setup.py Mar 2, 2019
@soumith soumith merged commit a7d8898 into pytorch:master Mar 6, 2019
@soumith
Copy link
Member

soumith commented Mar 6, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants