-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port tests for F.gaussian_blur GaussianBlur #7935
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7935
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 7 Unrelated FailuresAs of commit 5919483 with merge base 4ac707a (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
) | ||
@pytest.mark.parametrize("dtype", [torch.float32, torch.float64, torch.float16]) | ||
@pytest.mark.parametrize("device", cpu_and_cuda()) | ||
def test_functional_image_correctness(self, kernel_size, sigma, canvas_size, dtype, device): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored this from
vision/test/test_functional_tensor.py
Line 1028 in 4ac707a
def test_gaussian_blur(device, image_size, dt, ksize, sigma, fn): |
which is hard to understand and also does some unnecessary work just to skip later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmeier!
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: matteobettini Differential Revision: D49600788 fbshipit-source-id: 8afacb9e7dd6eba19f2212d8efa260f733bcb473
Follow-up to #7887.
cc @vfdev-5