Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a tensor of shape when not tracing #7942

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 7, 2023

This is a small follow up on #7592 that makes this Dynamo exportable.

Signed-off-by: Edward Z. Yang ezyang@meta.com

This is a small follow up on pytorch#7592
that makes this Dynamo exportable.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7942

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d50177f with merge base e13b8f5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezyang

@NicolasHug NicolasHug merged commit 65d50d0 into pytorch:main Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
Summary: Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Reviewed By: matteobettini

Differential Revision: D49600781

fbshipit-source-id: 374a98652b1c9e57429edfbafb42caddf4f4365d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants