-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docstring example for resnet_fpn_backbone #7957
Conversation
Add missing imports and use fix deprecated use of `backbone_name' as positional parameter.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7957
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9381d8b with merge base 0b41ff0 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! However, I can't find any mention of this function in the docs.
@@ -79,8 +79,10 @@ def resnet_fpn_backbone( | |||
|
|||
Examples:: | |||
|
|||
>>> import torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this import here? That should be obvious, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way it's copy-pastable to ipython and maybe eventually we can enable doctests.
Hey @kit1980! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: matteobettini Differential Revision: D49600792 fbshipit-source-id: 0b8a8da567a09fe4df546e8e5b8a775d8d8a0c4f
Add missing imports and fix deprecated use of `backbone_name' as positional parameter.