Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark SBU download as not accessible in tests #7970

Merged
merged 1 commit into from
Sep 18, 2023
Merged

mark SBU download as not accessible in tests #7970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_datasets_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ def url_parametrization(*dataset_urls_and_ids_fns):
kinetics,
kitti,
places365,
sbu,
)
def test_url_is_accessible(url):
"""
Expand All @@ -380,6 +379,7 @@ def test_url_is_accessible(url):

@url_parametrization(
stanford_cars, # https://github.com/pytorch/vision/issues/7545
sbu, # https://github.com/pytorch/vision/issues/7964
)
@pytest.mark.xfail
def test_url_is_not_accessible(url):
Expand All @@ -391,4 +391,4 @@ def test_url_is_not_accessible(url):
If you see this test failing, find the offending dataset in the parametrization and move it to
``test_url_is_accessible``.
"""
retry(lambda: assert_url_is_accessible(url))
assert_url_is_accessible(url)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driveby. Since we assert that the URL is not accessible by trying and xfailing afterwards, there is no need for retries.

Loading