Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InferenceSession call to latest format #7982

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Update InferenceSession call to latest format #7982

merged 3 commits into from
Sep 22, 2023

Conversation

thiagocrepaldi
Copy link
Contributor

@thiagocrepaldi thiagocrepaldi commented Sep 21, 2023 •
edited by pytorch-bot bot
Loading

Fixes: #7980
Reverts: #7981

The actual fix is a simple update call convention for onnxruntime. No need to skip latest ORT version

@vfdev-5 @seemethere @pmeier

cc @pmeier @neginraoof @justinchuby

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7982

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit db07725 with merge base cb512ea (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@thiagocrepaldi thiagocrepaldi mentioned this pull request Sep 21, 2023
Closed
pmeier
pmeier reviewed Sep 22, 2023
View reviewed changes
test/test_onnx.py Outdated Show resolved Hide resolved
@pmeier
Copy link
Collaborator

pmeier commented Sep 22, 2023

ONNX job is green: https://github.com/pytorch/vision/actions/runs/6271822156/job/17032158532?pr=7982

@justinchuby can you review this PR?

@thiagocrepaldi
Copy link
Contributor Author

ONNX job is green: https://github.com/pytorch/vision/actions/runs/6271822156/job/17032158532?pr=7982

@justinchuby can you review this PR?

We need reviews from @vfdev-5 @seemethere for merging :)

@pmeier
Copy link
Collaborator

pmeier commented Sep 22, 2023

We need reviews from @vfdev-5 @seemethere for merging :)

We don't. My approval is enough. But since I don't have much ONNX experience, I wanted to make sure the fix is good.

pmeier
pmeier approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thiagocrepaldi!

@pmeier pmeier merged commit 35677ec into pytorch:main Sep 22, 2023
60 of 63 checks passed
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
@NicolasHug @facebook-github-bot
[fbsync] Update InferenceSession call to latest format (#7982)
0fee15d 
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de>

Reviewed By: matteobettini

Differential Revision: D49600782

fbshipit-source-id: e7fdc0d2f7e79838b65d02f8d7f732ed68411bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed module: onnx module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ONNX tests fail due to upstream bug
4 participants
@thiagocrepaldi @pmeier @justinchuby @facebook-github-bot