Fixed markup in functional.py #8007
Conversation
Due to a missing colon in the role markup ":meth:" (short for "method"), the documentation at https://pytorch.org/vision/master/generated/torchvision.transforms.functional.rgb_to_grayscale.html contained the sentence "For inputs in other color spaces, please, consider using meth:", which happens to be really terrible advice.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8007
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5d87844 with merge base 48f8473 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @TilmannR! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I hope you'll forgive me, but I'm just so curious to see what will happen, if I never sign the CLA. Adding a single character to a single file to fix pre-existing markup is obviously not a copyrightable change and therefore shouldn't require any licensing agreement. |
Sorry, saw this too late before I approved. What will happen is simple: we can't accept the PR. Not even if we wanted to, since the CLA check is the only enforced check that needs to be green before we even can merge. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D50789099 fbshipit-source-id: 394252b013673acab9e82053f04ec4406eed1f04
Due to a missing colon in the role markup
:meth:(short for "method"), the documentation for rgb_to_grayscale contained the sentence "For inputs in other color spaces, please, consider using meth:", which happens to be really terrible advice.