port prototype tests to new utilities #8022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8022
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit cb5c813 with merge base 67f3ce2 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Oct 5, 2023
| ], | ||
| ) | ||
|
|
||
| def make_label(*, extra_dims=(), categories=10, dtype=torch.int64, device="cpu"): |
There was a problem hiding this comment.
I've opted to move this here from the previous prototype_common_utils module, since this module was the only one that imported from there. Plus, we had unused stuff in prototype_common_utils.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Reviewed By: vmoens Differential Revision: D50789081 fbshipit-source-id: 8a96e3a69c65b77f72172828516cdfc8b4ac3e74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8013 (comment). The prototype tests are not legacy as they will not be removed. This PR migrates the used utilities to the current ones.
cc @vfdev-5 @bjuncek