Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opchecks for RoiAlign #8057

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 21, 2023

Towards #8055

cc @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8057

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 018b581 with merge base 68161e9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

"status": "xfail"
}
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving the mps-related stuff as xfail for now, we can fix them eventually in other PRs.

@NicolasHug NicolasHug requested a review from pmeier October 23, 2023 11:20
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit 3fb88b3 into pytorch:main Oct 23, 2023
61 of 64 checks passed
@NicolasHug NicolasHug deleted the opcheck_roialign branch October 23, 2023 11:21
@NicolasHug NicolasHug added the pt2 label Nov 13, 2023
facebook-github-bot pushed a commit that referenced this pull request Nov 13, 2023
Reviewed By: vmoens

Differential Revision: D50789095

fbshipit-source-id: 0fce78ae86366f72961a11068d785002fd000b73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants