-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quantized references #8073
Fix quantized references #8073
Conversation
parser.add_argument("--backend", default="PIL", type=str.lower, help="PIL or tensor - case insensitive") | ||
parser.add_argument("--use-v2", action="store_true", help="Use V2 transforms") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual fix. These fields are accessed in
vision/references/classification/train.py
Lines 147 to 148 in a63f98a
backend=args.backend, | |
use_v2=args.use_v2, |
but since the args
parameter comes from this script (and not from train.py
), they need to be defined here as well.
Since the --backend
parameter already existed in this file, I decided to break BC and rename it into qbackend
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reflected in the README, e.g.
vision/references/classification/README.md
Line 292 in a63f98a
5. backend: 'fbgemm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
parser.add_argument("--backend", default="PIL", type=str.lower, help="PIL or tensor - case insensitive") | ||
parser.add_argument("--use-v2", action="store_true", help="Use V2 transforms") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reflected in the README, e.g.
vision/references/classification/README.md
Line 292 in a63f98a
5. backend: 'fbgemm' |
Reviewed By: vmoens Differential Revision: D50789093 fbshipit-source-id: 17b6840f89063eeef1fb429ff04817f46e5919eb
Fixes #8069