-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependency from macOS/Conda binaries #8077
Conversation
Update the dependency. Currently only Linux + conda ships FFmpeg integration.
@NicolasHug Review please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mthrok!
@pmeier Thanks. I don't have a merge privilege. Could you merge it? |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: vmoens Differential Revision: D51391970 fbshipit-source-id: aa36c68e85a5fc3a348f44f35f7d7f618ee24d57
This commit updates the dependency description on Conda package,
so that FFmpeg is installed only on platforms on which torchvision comes with the corresponding extension.
vision/setup.py
Lines 366 to 367 in a8ebd0b
https://github.com/pytorch/vision/actions/runs/6678010959/job/18148611653#step:14:106
https://github.com/pytorch/vision/actions/runs/6695315792/job/18190638421?pr=8077#step:9:199