Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for tv tensors in torch compile for func ops #8110

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Added support for tv tensors in torch compile for func ops #8110

merged 3 commits into from
Nov 13, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Nov 10, 2023

Description:

  • With this added we can torch compile functional ops with subclasses

Context: https://github.com/pytorch/vision/pull/8092/files#r1389097518

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8110

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 1827548 with merge base 517f6d3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 mentioned this pull request Nov 10, 2023
Open
NicolasHug
NicolasHug approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vfdev-5

torchvision/tv_tensors/__init__.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 merged commit 0e2a5ae into main Nov 13, 2023
60 of 64 checks passed
@vfdev-5 vfdev-5 deleted the compile_funciontal_support_tv_tensors branch November 13, 2023 14:09
@github-actions GitHub Actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Nov 16, 2023
@NicolasHug @facebook-github-bot
[fbsync] Added support for tv tensors in torch compile for func ops (#…
856e7cf 
…8110)

Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: vmoens

Differential Revision: D51391968

fbshipit-source-id: 90b6b67404f5faac9ff4effcf3d839f77fc9f7b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: transforms pt2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @NicolasHug @facebook-github-bot