Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated path parameter to VideoReader and made src mandatory #8125

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Remove deprecated path parameter to VideoReader and made src mandatory #8125

merged 8 commits into from
Nov 20, 2023

Conversation

NicolasHug
Copy link
Member

plus some minimal input check tests.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8125

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (32 Unrelated Failures)

As of commit 13eab0d with merge base 127e8a7 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug commented Nov 20, 2023
View reviewed changes
torchvision/io/video_reader.py Outdated
src = path
warnings.warn("path is deprecated and will be removed in 0.17. Please use src instead")
if isinstance(src, str) and not src:
raise ValueError("src cannot be empty")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly needed, we could just rely on the error from the backend. This line just makes that error consistent across backends and thus is easier to test. If we remove this line, I'll just remove the test.

@NicolasHug NicolasHug requested review from vfdev-5 and pmeier November 20, 2023 11:58
vfdev-5
vfdev-5 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vfdev-5
vfdev-5 reviewed Nov 20, 2023
View reviewed changes
test/test_videoapi.py Outdated Show resolved Hide resolved
@NicolasHug NicolasHug merged commit 893b4ab into pytorch:main Nov 20, 2023
1 check passed
@NicolasHug NicolasHug deleted the elajnaelfjnaelfjn branch November 20, 2023 14:54
facebook-github-bot pushed a commit that referenced this pull request Jan 15, 2024
@NicolasHug @facebook-github-bot
[fbsync] Remove deprecated path parameter to VideoReader and made src…
d5495cd 
… mandatory (#8125)

Summary: Co-authored-by: vfdev <vfdev.5@gmail.com>

Reviewed By: vmoens

Differential Revision: D52538998

fbshipit-source-id: a94116a744de3180bf9eea3fbfc02202a681cdd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@pmeier pmeier Awaiting requested review from pmeier

Assignees
No one assigned
Labels
cla signed deprecation module: video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @vfdev-5 @facebook-github-bot