Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip jpeg encoding/decoding tests on MacOS #8145

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Skip jpeg encoding/decoding tests on MacOS #8145

merged 3 commits into from
Dec 5, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Dec 5, 2023 •
edited by pytorch-bot bot
Loading

These tests are failing on M1 - see #8031

I don't know why. But there's no point keeping the CI red as it's been for weeks.

cc @pmeier

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8145

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (32 Unrelated Failures)

As of commit b4ec9e4 with merge base 1ababf9 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug commented Dec 5, 2023
View reviewed changes
test/test_image.py Outdated
@@ -419,6 +420,7 @@ def test_encode_jpeg_errors():
encode_jpeg(torch.empty((100, 100), dtype=torch.uint8))


@pytest.skipif(IS_MACOS, reason="https://github.com/pytorch/vision/issues/8031")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we would only skip for M1 and not all darwin, but it doesn't really matter since the non-M1 builds will be dropped very soon.

pmeier
pmeier approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Test failure is not related:

FAILED test/test_transforms_v2.py::TestLinearTransform::test_transform[cpu-dtype1-make_image_tensor] - AssertionError: Tensor-likes are not close!

@NicolasHug NicolasHug merged commit 526ec93 into pytorch:main Dec 5, 2023
2 checks passed
@NicolasHug NicolasHug deleted the aelfjnalefjnaljenf branch December 5, 2023 13:55
facebook-github-bot pushed a commit that referenced this pull request Jan 16, 2024
@NicolasHug @facebook-github-bot
[fbsync] Skip jpeg encoding/decoding tests on MacOS (#8145)
08928d8 
Reviewed By: vmoens

Differential Revision: D52539015

fbshipit-source-id: 77897ef7616da523e9a5eac0447d22cdc281d86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @pmeier @facebook-github-bot