Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for num_class in test_model.py #815

Merged
merged 7 commits into from
Mar 26, 2019
Merged

Add test for num_class in test_model.py #815

merged 7 commits into from
Mar 26, 2019

Conversation

ekagra-ranjan
Copy link
Contributor

Passing 'num_class' equal to a number other than 1000 helps in making the test more enforcing in nature.

update before transform
The update modifies the test to check whether the model can successfully load the pretrained weights. Will raise an error if the model parameters are incorrectly defined or named.
Passing num_class equal to a number other than 1000 helps in making the test more enforcing in nature.
@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #815 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   51.67%   51.67%           
=======================================
  Files          34       34           
  Lines        3334     3334           
  Branches      532      532           
=======================================
  Hits         1723     1723           
+ Misses       1483     1482    -1     
- Partials      128      129    +1
Impacted Files Coverage Δ
torchvision/datasets/imagenet.py 21.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c33bd7...3027e24. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 83d3770 into pytorch:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants